Support triple quote strings to disambiguate between String and EscapedJsonPointer#5655
Merged
Merged
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Collaborator
|
Thank you for your contribution. |
Collaborator
|
@cwperks please add some tests testing the conditionals in |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
KarstenSchnitter,
chenqi0805,
dinujoh,
dlvenable,
engechas,
graytaylor0,
kkondaka,
oeyh,
san81,
sb2k16 and
srikanthjg
as code owners
Member
Author
|
Added a new IT in GenericExpressionEvaluator_ConditionalIT |
dlvenable
requested changes
May 1, 2025
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
changed the title
Signed-off-by: Craig Perkins <cwperx@amazon.com>
dlvenable
previously approved these changes
May 7, 2025
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Member
Author
|
Resolved the conflicts |
dlvenable
approved these changes
May 21, 2025
kkondaka
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempts to resolve an issue with Strings where the first character is a forward slash. Currently the grammar parses these as escaped JSON pointers which renders it impossible to match to any string that begins with a forward slash. The changes in this PR support triple quote for Strings to help with disambiguation from Escaped JSON Pointers.
I discovered this issue when trying to build a dashboard using audit logs generated from the security plugin and drop repeat events which sometimes includes the path of the request which always begins with a forward slash.
Issues Resolved
Resolves #1188
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.